count collection items with the SolrService directly #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove a hard dependency on ActiveFedora by querying solr directly instead of using the `Relation#count` interface. there are other methods here using similar queries, but working out the relationship with `Blacklight::AccessControls::Enforcement` is going to take some more work. for one thing, we have local `Enforcement` additions that are being bypassed (inappropriately?) by the existing queries.
|
Right, it looks like those other ones are using |
it sounds like you're implying that's appropriate? if so, i'm not following why. could you help me with whatever i'm overlooking? |
|
Sorry, no, I wasn't trying to say that I thought it appropriate. I'm happy to help as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove a hard dependency on ActiveFedora by querying solr directly instead of
using the
Relation#countinterface.there are other methods here using similar queries, but working out the
relationship with
Blacklight::AccessControls::Enforcementis going to takesome more work. for one thing, we have local
Enforcementadditions that arebeing bypassed (inappropriately?) by the existing queries.
@samvera/hyrax-code-reviewers